fix(types): expose Modal native ref prop#56952
Closed
ya-nsh wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
huntie
approved these changes
Jun 1, 2026
| @@ -1540,6 +1541,10 @@ const KeyboardAvoidingViewTest = () => <KeyboardAvoidingView enabled />; | |||
|
|
|||
| const ModalTest = () => <Modal hardwareAccelerated />; | |||
| const ModalTest2 = () => <Modal hardwareAccelerated testID="modal-test-2" />; | |||
| const ModalRefTest = () => { | |||
| const modalRef = React.useRef<Modal & HostInstance>(null); | |||
Member
There was a problem hiding this comment.
This is an exotic but valid usage 😅
After react-native-community/discussions-and-proposals#1003, this will be replaceable with ModalInstance soon, hopefully.
| /** | ||
| * A ref to the native Modal component. | ||
| */ | ||
| modalRef?: React.RefObject<Modal | null> | undefined; |
|
@huntie has imported this pull request. If you are a Meta employee, you can view this in D107081018. |
huntie
added
the
JS API stabilization (1.0)
Collaborator
|
This pull request was successfully merged by @ya-nsh in 7cc8c76 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
modalRefto the hand-writtenModalTypeScript declarationsReact.RefObjectref prop typing patternsmodalRefThis replaces #56889, which GitHub auto-closed after its pull ref got stuck on a bad force-pushed commit. The branch here contains the same scoped fix plus the review feedback from #56889.
Modalalready acceptsmodalRefat runtime and the generated API snapshot already includes it. The hand-written declarations were the odd one out, so TypeScript users could not pass the supported ref prop without a local cast.Changelog:
[General] [Fixed] - Expose Modal native ref prop in TypeScript declarations
Test Plan
npx prettier --check packages/react-native/Libraries/Modal/Modal.d.ts packages/react-native/types/__typetests__/index.tsxnpm run test-typescript -- --pretty falsenpm run build-typesnpm run test-generated-typescript -- --pretty false